Skip to content

Missing GeoDistanceOrder's direction #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

beyond-seunghyun
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2601

@pivotal-cla
Copy link

@beyond-seunghyun Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@beyond-seunghyun Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 23, 2023
@sothawo sothawo merged commit 8a164b1 into spring-projects:main Jun 24, 2023
@sothawo
Copy link
Collaborator

sothawo commented Jun 24, 2023

Thank you very much for finding and fixing this.

One minor remark: You missed adding a test that fails before your change and works after it (although you checked that off). I added one in b7570ff

sothawo pushed a commit that referenced this pull request Jun 24, 2023
Original Pull Request #2602
Closes #2601

(cherry picked from commit 8a164b1)

Polishing

(cherry picked from commit b7570ff)

add implementation for old client
sothawo pushed a commit that referenced this pull request Jun 25, 2023
Original Pull Request #2602
Closes #2601

(cherry picked from commit 8a164b1)

Polishing

(cherry picked from commit b7570ff)

add implementation for old client

(cherry picked from commit d43b44b)

# Conflicts:
#	src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java
#	src/main/java/org/springframework/data/elasticsearch/client/erhlc/RequestFactory.java
@beyond-seunghyun
Copy link
Contributor Author

@sothawo
oops... my fault... thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing GeoDistanceOrder's direction in request
4 participants